Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual ports inherit capabilities of their parent ports (#234) #235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mathisrichter
Copy link
Contributor

@mathisrichter mathisrichter commented Mar 22, 2022

Signed-off-by: Mathis Richter [email protected]

Issue Number: #234

Objective of pull request: Virtual ports should inherit the capabilities of their parent ports

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • When a virtual port is created, it has a number of generic capabilities, like connecting. But when creating a virtual port on a RefPort, the user cannot use the connect_var() method on the virtual port.

What is the new behavior?

  • When a virtual port is created, it inherits those capabilities of its parent port that make sense for the virtual port. This includes connect_var() from RefPort.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@mathisrichter mathisrichter added the 1-feature New feature request label Mar 22, 2022
@mathisrichter mathisrichter self-assigned this Mar 22, 2022
@mathisrichter
Copy link
Contributor Author

Apparently something is wrong with the new library dependency I added. Will look into this asap.

Signed-off-by: Mathis Richter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant