-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparsity netx pr #238
Sparsity netx pr #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Michaeljurado42 This looks good. Thanks for this one. Only one suggestion. Let's use sparse_fc_layer
instead of sparsity_map
…ests to test if sparse_fc_layer creates Sparse types in lava
Also, a final naming change which may be beneficial could be to rename the Thank you for the feedback so far! |
On board with that. It would break a lot of things at this stage of this project though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Michaeljurado42
Issue Number: #239
Objective of pull request: This code provides netX with the ability to interpret synapses as sparse types when converting SNNs from lava-dl to lava.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information