Show harmony suggestion when using for-of loops

lautis · Dec 9, 2017 · 6ecb277 · 6ecb277
1 parent dd46f20
commit 6ecb277
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## next
+
+- show harmony suggestion when using for-of loops
+
 ## 4.0.1 (3 December 2017)
 
 - update UglifyJS to 3.2.1

diff --git a/lib/uglifier.rb b/lib/uglifier.rb
@@ -225,7 +225,7 @@ def harmony?
 
   def error_message(result)
     result['error']['message'] +
-      if result['error']['message'].start_with?("Unexpected token:") && !harmony?
+      if result['error']['message'].start_with?("Unexpected token") && !harmony?
         ". To use ES6 syntax, harmony mode must be enabled with " \
         "Uglifier.new(:harmony => true)."
       else

diff --git a/spec/uglifier_spec.rb b/spec/uglifier_spec.rb
@@ -20,7 +20,7 @@
     end
 
     it "raises an error when minifying JS with Harmony without harmony option" do
-      source = "const foo = () => bar();"
+      source = "for (var value of array) { doSomething(value) }"
       expect { Uglifier.new(:compress => false).compile(source) }
         .to raise_error(Uglifier::Error, /harmony/)
     end