App icon on linux broken

[OiYouYeahYou]

Describe the bug
On Ubuntu the app icon is either not set or missing

To Reproduce
Steps to reproduce the behaviour:

1. Download app image
2. Run app image on Ubuntu
3. Look at app icon in the dock/app-bar
4. Observe that it is the "iconless icon" given to apps without icons

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 19.04 with GNOME

Additional context
Willing to accept PR? It's often an easy fix

[lauthieb]

Thanks a lot @OiYouYeahYou for reporting this bug.
I don't have any Linux so I can't investigate this. Hope that anyone could fix this issue.
Have a nice day!

[OiYouYeahYou]

I'm looking at the code now. Do you have a raw SVG file I can use to convert into the relevant formats directly?

[lauthieb]

Just PNG sorry :(

[lauthieb]

You can crop this image : https://github.com/lauthieb/code-notes/blob/master/src/renderer/assets/img/code-notes-logo-black-full.png
and convert to SVG if you want.

[TheFern2]

Is this still an issue? I used lubuntu, and icon works fine on that one, I don't have ubuntu VM and I don't like the distro lol.

Can you please go to ~/.local/share/applications or whatever path your .desktop file is, and show us the contents of that files. It should be called appimagekit-code-notes.desktop

I believe this is an electron issue as per the two issues below:
electron-userland/electron-builder#2269
electron-userland/electron-builder#748

Can you try on src/main/index.js adding inside BrowserWindow:

mainWindow= new BrowserWindow({
   ...
   icon: path.join(__dirname, '/build/icons/256x256.png')
})

Then do a build test, and let us know if it worked, some users on those thread said yes other no:

npm run build

[OiYouYeahYou]

I cloned a fresh copy of master and made the suggested changes. The icon still doesn't work unfortunately

diff --git a/src/main/index.js b/src/main/index.js
index cc380f6..f244bb0 100644
--- a/src/main/index.js
+++ b/src/main/index.js
@@ -1,4 +1,5 @@
 import { app, BrowserWindow, Menu } from 'electron'; // eslint-disable-line
+import { join } from 'path';
 
 /**
  * Set `__static` path to static files in production
@@ -27,6 +28,7 @@ function createWindow() {
     width: 1160,
     minHeight: 500,
     minWidth: 900,
+    icon: join(__dirname, 'build/icons/255x256.png'),
   });
 
   mainWindow.loadURL(winURL);

@kodaman2 as an aside: lubuntu, ubuntu, kubuntu and xubuntu are all the same distribution. The only major difference is which {,l,k,x}ubuntu-desktop package is installed. And installing the different DE is just a matter of running sudo apt install [,l,k,x]ubuntu-desktop

[TheFern2]

If is all the same, then I dunno, it works perfect on my lubuntu. Btw you have a typo on the diff you pasted. 255x256.png, might want to to try 256x256.png

[OiYouYeahYou]

The typo makes no difference :(

[TheFern2]

Any errors on console?

Can you include your desktop file contents.

Perhaps what you mentioned about desktop options has something to do with it. Link below edited the desktop file for gnome. I'll have to check what I'm running I've never gotten into the details of different desktops tbh.

laurent22/joplin#86 (comment)

[TheFern2]

I've ran Ubuntu 19.04 with gnome with no issues. Not much I can think of to debug this issue if is working on 3 different linux systems, I've tried. Does the icon shows on the applications menu?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.