Fix mutated idents in functions which are inlined more than once #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function inlining directly drops the inlined function's body into the place it gets inlined. This is problematic for mutable Idents -- in particular, the renamer could do some very strange things as it tried to rename the same Ident to more than one thing. For example, the included test case was previously renamed to the following:
Therefore all Idents (which aren't function parameters that get substituted away) need to get copied during inlining.