Fix for "exit code is always zero on Windows" regression #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Delete exit code file even if it is read-only.
laurentj
added a commit
that referenced
this pull request
Jan 20, 2016
…dows Fix for "exit code is always zero on Windows" regression
|
Thanks you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like exit code is always zero on Windows again (was fixed in #50). Regression was caused by 911fcb6.
The main reason of the regression is that
%EXITCODE%inEXIT %EXITCODE%command is expanded before theset /pcommand is executed.Another problem is that a file with exit code is always created read-only and
delcommand cannot delete it.