Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #8256: Don't start window minimized in GNOME #8441

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jul 9, 2023

Summary

This pull request prevents Joplin from starting minimized on GNOME.

This should fix #8256.

Explanation

At present, Joplin always starts minimized (unless running in dev mode), and is then shown or remains hidden based on the startMinimized setting.

However, the GNOME desktop environment seems to not always show a minimized window when requested. As such, this pull request should fix Joplin windows sometimes not appearing (#8256).

Testing plan

This pull request changes some logic related to the "start minimized" feature. Thus, this feature needs to be manually tested.

  • Launch Joplin (not in dev mode, so use npx electron ., not yarn start)
  • Enable start minimized
  • Re-launch Joplin
  • Verify that Joplin starts minimized and can be opened.

@laurent22 laurent22 merged commit 7ef591f into laurent22:dev Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joplin is invisible on GNOME on first start after system reboot
2 participants