Windows 10 Desktop: Fixes #7528: Fixed the Joplin crashing Full Screen PDF error #7541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
But why is the element being unmounted before the event handler has been removed? There's something not right to the logic here, and solving it with |
|
Since this is urgent I ended up fixing it myself |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the Full-Screen window crashing on the desktop whenever the close button on the top-right corner was clicked.
Issue #7528 is fixed. Previously whenever the PDF was closed, it showed an error, now it is being fixed. The problem was removing the event listener from the null object. Hence a null check is required. Here is the attached result.
Joplin.DEV.-.C__Users_rajee_.config_joplindev-desktop.2022-12-27.16-13-53.mp4