Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Add keyboard-activatable markdown commands (e.g. bold, italicize) #6707

Merged
merged 103 commits into from
Aug 8, 2022
Merged

Mobile: Add keyboard-activatable markdown commands (e.g. bold, italicize) #6707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
103 commits
Select commit Hold shift + click to select a range
f14d3b5
Mobile: Syntax highlighting for TeX, code blocks
personalizedrefrigerator Jun 24, 2022
6899316
Fix math missing enclosing tag.
personalizedrefrigerator Jun 24, 2022
04f7cd4
Minor code cleanup
personalizedrefrigerator Jun 24, 2022
d306cff
Merge remote-tracking branch 'upstream/dev' into pr/languageSupportRe…
personalizedrefrigerator Jun 24, 2022
f993bce
Adjust dark mode TeX color to increase contrast with keywords
personalizedrefrigerator Jun 24, 2022
28da39e
Make TeX matching more consistent with rendered markdown
personalizedrefrigerator Jun 24, 2022
94d457e
Rename MarkdownTeXParser to MarkdownMathParser
personalizedrefrigerator Jun 24, 2022
c41050c
Merge branch 'dev' into pr/languageSupportRebased
laurent22 Jun 24, 2022
37753cc
Don't render math if the user has disabled it.
personalizedrefrigerator Jun 25, 2022
3b08dc8
Update .gitignore, .eslintignore with auto-generated .js files
personalizedrefrigerator Jun 25, 2022
45425c9
Fix settings serialization
personalizedrefrigerator Jun 25, 2022
2a17e90
Markdown toolbar with bold and italicize buttons
personalizedrefrigerator Jun 14, 2022
b21192e
Fix import failure in CodeMirror.ts
personalizedrefrigerator Jun 16, 2022
d7d30ae
Highlight bold, italic buttons when within bolded/italicized regions
personalizedrefrigerator Jun 15, 2022
f802ebe
Editor toolbar: header, inline code, and list
personalizedrefrigerator Jun 16, 2022
2feba46
Make code button toggle inline or block code, depending on selection
personalizedrefrigerator Jun 17, 2022
4a9f5ed
Break markdown toolbar into submenus
personalizedrefrigerator Jun 19, 2022
a5ecafa
Toolbar: Add math and numbered list buttons
personalizedrefrigerator Jun 19, 2022
a5576eb
Add indent/deindent buttons, fix ordered list enable
personalizedrefrigerator Jun 19, 2022
2273e70
Mobile editor: Keybindings for bold, code, math
personalizedrefrigerator Jun 20, 2022
7484214
Fix math-related markdown bugs
personalizedrefrigerator Jun 20, 2022
1e3e5f1
Push toolbar off screen when not enough space.
personalizedrefrigerator Jun 20, 2022
8ce6937
Start work on link dialog
personalizedrefrigerator Jun 23, 2022
03d5739
Working link dialog
personalizedrefrigerator Jun 23, 2022
b53bc46
Merge branch 'pr/languageSupportRebased' into pr/markdownToolbar
personalizedrefrigerator Jun 25, 2022
87a317e
Fix inline code with no children not being styled properly
personalizedrefrigerator Jun 26, 2022
271af89
Merge branch 'pr/languageSupportRebased' into pr/markdownToolbar
personalizedrefrigerator Jun 26, 2022
8165485
Add checklist button to toolbar
personalizedrefrigerator Jun 26, 2022
229a943
Add H5 button to toolbar
personalizedrefrigerator Jun 26, 2022
178d4cc
Add hide keyboard button to toolbar
personalizedrefrigerator Jun 26, 2022
3596728
Allow opening search dialog from markdown toolbar
personalizedrefrigerator Jun 26, 2022
49c0416
Remove duplicate file
personalizedrefrigerator Jun 26, 2022
3670856
Add search button to markdown toolbar
personalizedrefrigerator Jun 26, 2022
99c60ca
Changes from code review (use camel instead of pascal case)
personalizedrefrigerator Jun 26, 2022
738d9e6
Merge remote-tracking branch 'upstream/dev' into pr/languageSupportRe…
personalizedrefrigerator Jun 26, 2022
0ca11ef
Merge branch 'pr/languageSupportRebased' into pr/markdownToolbar
personalizedrefrigerator Jun 26, 2022
294b220
Merge remote-tracking branch 'upstream/dev' into pr/markdownToolbar
personalizedrefrigerator Jun 26, 2022
0c9fe82
Re-fix not scrolling to selection on keyboard toggle
personalizedrefrigerator Jun 26, 2022
4c7117c
Fix off-by-one error in markdown math parser
personalizedrefrigerator Jun 26, 2022
a001298
Improve selection when adding headers, lists
personalizedrefrigerator Jun 27, 2022
2c41602
Refactor
personalizedrefrigerator Jun 28, 2022
a88213e
Add formatting tests
personalizedrefrigerator Jun 28, 2022
29cb40a
Fix constness error
personalizedrefrigerator Jun 28, 2022
6473312
Add additional tests
personalizedrefrigerator Jun 28, 2022
64591d8
Fix .eslintignore
personalizedrefrigerator Jun 28, 2022
899e810
Merge branch 'dev' into pr/markdownToolbar
personalizedrefrigerator Jun 28, 2022
46da331
Create yarn test-ci command
personalizedrefrigerator Jun 28, 2022
553b945
Re-implement search dialog in react native
personalizedrefrigerator Jun 30, 2022
0b28143
Link yarn test-ci to yarn test
personalizedrefrigerator Jun 30, 2022
53cc093
Replace toBeTruthy/toBeFalsey with stronger .toBe versions
personalizedrefrigerator Jun 30, 2022
cda72f1
Stylistic changes to make find/replace dialog match toolbar
personalizedrefrigerator Jun 30, 2022
6e7dd9f
Fix block math not toggling properly within block quotes
personalizedrefrigerator Jun 30, 2022
9346eab
Close search dialog on back key press
personalizedrefrigerator Jun 30, 2022
b7409b3
Fix initial white flash on opening of editor
personalizedrefrigerator Jun 30, 2022
3bab3cb
Prefer custom hooks
personalizedrefrigerator Jun 30, 2022
6485f54
Merge remote-tracking branch 'upstream/dev' into pr/markdownToolbar
personalizedrefrigerator Jun 30, 2022
b16b06c
Prefer camelCase to UPPERCASE_SNAKE_CASE for constants
personalizedrefrigerator Jul 1, 2022
0e1eaba
Preserve list indentation, additional tests
personalizedrefrigerator Jul 1, 2022
d1eabaf
Additional comments, fix formatting after linter applied
personalizedrefrigerator Jul 1, 2022
74ee65c
Prefer no specified return type to :any
personalizedrefrigerator Jul 1, 2022
f1427fe
Test for updating a link
personalizedrefrigerator Jul 1, 2022
0f7834e
Markdown toolbar accessibility fixes
personalizedrefrigerator Jul 1, 2022
0cf0cff
Link dialog: Make header larger, underline inputs
personalizedrefrigerator Jul 1, 2022
c9b5b08
Increase size of inputs in edit link dialog, make first input auto-focus
personalizedrefrigerator Jul 2, 2022
8a5b836
Create block region when toggling math/code in an empty inline region
personalizedrefrigerator Jul 2, 2022
6f17c65
Fix 'undefined has no property 1' exception in broken link parse
personalizedrefrigerator Jul 2, 2022
127521f
Flush bulleted lists to left (no initial space)
personalizedrefrigerator Jul 2, 2022
3f98fab
Math regions need an ending delimiter
personalizedrefrigerator Jul 2, 2022
6210d6c
Merge branch 'dev' into pr/markdownToolbar
personalizedrefrigerator Jul 2, 2022
f2152fe
Use space indentation to work around list auto-indent issue
personalizedrefrigerator Jul 2, 2022
57a1edc
iOS: Fix wrong font being used for base text
personalizedrefrigerator Jul 2, 2022
073abb4
SearchPanel: Ensure search input is as tall as the surrounding button…
personalizedrefrigerator Jul 2, 2022
45b6060
iOS: Fix possible overscroll in beta editor
personalizedrefrigerator Jul 3, 2022
594ee8f
Revert iOS scroll fix --- outside of the scope of this PR
personalizedrefrigerator Jul 3, 2022
b162bcb
Fix list toggling bugs
personalizedrefrigerator Jul 4, 2022
ebdf16e
Automatic list renumbering
personalizedrefrigerator Jul 7, 2022
ac5a53e
Add spellcheck button
personalizedrefrigerator Jul 7, 2022
dbbdfd1
Switch to JavaDoc-like comments for better editor support
personalizedrefrigerator Jul 8, 2022
f2b9f75
Add insert time button to markdown toolbar
personalizedrefrigerator Jul 8, 2022
8ced130
Attempt: Code refactoring
personalizedrefrigerator Jul 11, 2022
54514a5
Write custom regexEscape --- require can‘t be used in bundled JS
personalizedrefrigerator Jul 11, 2022
07ee048
Add markdownMathParser tests, fix bugs found while creating tests
personalizedrefrigerator Jul 12, 2022
03d08b0
Merge remote-tracking branch 'upstream/dev' into pr/markdownToolbar
personalizedrefrigerator Jul 22, 2022
dcfc63f
Merge remote-tracking branch 'upstream/dev' into pr/markdownToolbar
personalizedrefrigerator Jul 29, 2022
d837ded
Partial refactor
personalizedrefrigerator Jul 29, 2022
0b25795
Merge remote-tracking branch 'upstream/dev' into pr/markdownToolbar
personalizedrefrigerator Jul 29, 2022
67e069c
Non-strict → strict equality
personalizedrefrigerator Jul 29, 2022
336c1b7
Fix minor spacing issue
personalizedrefrigerator Jul 29, 2022
798cf8e
Improve test descriptions
personalizedrefrigerator Jul 29, 2022
50f447a
Change block-style comment to inline comment
personalizedrefrigerator Jul 29, 2022
706171a
Fix eqeq, reformat some of the tests
personalizedrefrigerator Jul 29, 2022
f91febf
Merge remote-tracking branch 'refs/remotes/origin/pr/markdownToolbar'…
personalizedrefrigerator Jul 29, 2022
aaa965e
Further test refactoring
personalizedrefrigerator Jul 29, 2022
9a8d79b
Move unrelated subtest
personalizedrefrigerator Jul 30, 2022
81708eb
Merge remote-tracking branch 'upstream/dev' into pr/markdownToolbar
personalizedrefrigerator Jul 31, 2022
60cd488
Fix missing file in .gitignore
personalizedrefrigerator Jul 31, 2022
28861ed
Remove markdown toolbar.
personalizedrefrigerator Jul 31, 2022
d684d7e
Reorganize tests to match file.method.test.ts format
personalizedrefrigerator Jul 31, 2022
8576be5
Switch to * for italicizing to match desktop app
personalizedrefrigerator Jul 31, 2022
a3bd461
Changes from code review
personalizedrefrigerator Aug 1, 2022
30afc79
Merge branch 'dev' into pr/markdownCommands
personalizedrefrigerator Aug 2, 2022
c7741b9
Remove nested describes in markdownReformatter.test.ts
personalizedrefrigerator Aug 6, 2022
2bfb248
Merge branch 'dev' into pr/markdownCommands
personalizedrefrigerator Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,24 +857,66 @@ packages/app-mobile/components/NoteBodyViewer/hooks/useSource.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/CodeMirror.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/CodeMirror.js
packages/app-mobile/components/NoteEditor/CodeMirror/CodeMirror.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/createEditor.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/createEditor.js
packages/app-mobile/components/NoteEditor/CodeMirror/createEditor.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/decoratorExtension.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/decoratorExtension.js
packages/app-mobile/components/NoteEditor/CodeMirror/decoratorExtension.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.bulletedVsChecklist.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.bulletedVsChecklist.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.bulletedVsChecklist.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.toggleTwice.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.toggleTwice.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.toggleTwice.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.togglingLists.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.togglingLists.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.togglingLists.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/syntaxHighlightingLanguages.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/syntaxHighlightingLanguages.js
packages/app-mobile/components/NoteEditor/CodeMirror/syntaxHighlightingLanguages.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/theme.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/theme.js
packages/app-mobile/components/NoteEditor/CodeMirror/theme.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/types.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/types.js
packages/app-mobile/components/NoteEditor/CodeMirror/types.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/webviewLogger.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/webviewLogger.js
packages/app-mobile/components/NoteEditor/CodeMirror/webviewLogger.js.map
packages/app-mobile/components/NoteEditor/EditLinkDialog.d.ts
packages/app-mobile/components/NoteEditor/EditLinkDialog.js
packages/app-mobile/components/NoteEditor/EditLinkDialog.js.map
packages/app-mobile/components/NoteEditor/NoteEditor.d.ts
packages/app-mobile/components/NoteEditor/NoteEditor.js
packages/app-mobile/components/NoteEditor/NoteEditor.js.map
packages/app-mobile/components/NoteEditor/SearchPanel.d.ts
packages/app-mobile/components/NoteEditor/SearchPanel.js
packages/app-mobile/components/NoteEditor/SearchPanel.js.map
packages/app-mobile/components/NoteEditor/SelectionFormatting.d.ts
packages/app-mobile/components/NoteEditor/SelectionFormatting.js
packages/app-mobile/components/NoteEditor/SelectionFormatting.js.map
packages/app-mobile/components/NoteEditor/types.d.ts
packages/app-mobile/components/NoteEditor/types.js
packages/app-mobile/components/NoteEditor/types.js.map
packages/app-mobile/components/SelectDateTimeDialog.d.ts
packages/app-mobile/components/SelectDateTimeDialog.js
packages/app-mobile/components/SelectDateTimeDialog.js.map
Expand Down
42 changes: 42 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,24 +846,66 @@ packages/app-mobile/components/NoteBodyViewer/hooks/useSource.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/CodeMirror.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/CodeMirror.js
packages/app-mobile/components/NoteEditor/CodeMirror/CodeMirror.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/createEditor.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/createEditor.js
packages/app-mobile/components/NoteEditor/CodeMirror/createEditor.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/decoratorExtension.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/decoratorExtension.js
packages/app-mobile/components/NoteEditor/CodeMirror/decoratorExtension.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.bulletedVsChecklist.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.bulletedVsChecklist.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.bulletedVsChecklist.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.toggleTwice.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.toggleTwice.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.toggleTwice.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.togglingLists.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.togglingLists.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownCommands.togglingLists.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownMathParser.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.test.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.test.js
packages/app-mobile/components/NoteEditor/CodeMirror/markdownReformatter.test.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/syntaxHighlightingLanguages.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/syntaxHighlightingLanguages.js
packages/app-mobile/components/NoteEditor/CodeMirror/syntaxHighlightingLanguages.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/theme.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/theme.js
packages/app-mobile/components/NoteEditor/CodeMirror/theme.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/types.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/types.js
packages/app-mobile/components/NoteEditor/CodeMirror/types.js.map
packages/app-mobile/components/NoteEditor/CodeMirror/webviewLogger.d.ts
packages/app-mobile/components/NoteEditor/CodeMirror/webviewLogger.js
packages/app-mobile/components/NoteEditor/CodeMirror/webviewLogger.js.map
packages/app-mobile/components/NoteEditor/EditLinkDialog.d.ts
packages/app-mobile/components/NoteEditor/EditLinkDialog.js
packages/app-mobile/components/NoteEditor/EditLinkDialog.js.map
packages/app-mobile/components/NoteEditor/NoteEditor.d.ts
packages/app-mobile/components/NoteEditor/NoteEditor.js
packages/app-mobile/components/NoteEditor/NoteEditor.js.map
packages/app-mobile/components/NoteEditor/SearchPanel.d.ts
packages/app-mobile/components/NoteEditor/SearchPanel.js
packages/app-mobile/components/NoteEditor/SearchPanel.js.map
packages/app-mobile/components/NoteEditor/SelectionFormatting.d.ts
packages/app-mobile/components/NoteEditor/SelectionFormatting.js
packages/app-mobile/components/NoteEditor/SelectionFormatting.js.map
packages/app-mobile/components/NoteEditor/types.d.ts
packages/app-mobile/components/NoteEditor/types.js
packages/app-mobile/components/NoteEditor/types.js.map
packages/app-mobile/components/SelectDateTimeDialog.d.ts
packages/app-mobile/components/SelectDateTimeDialog.js
packages/app-mobile/components/SelectDateTimeDialog.js.map
Expand Down
Loading