Desktop: Install default plugins on first-app-start

packages/app-desktop/app.ts

@@ -63,6 +63,7 @@ import checkForUpdates from './checkForUpdates';
 import { AppState } from './app.reducer';
 import syncDebugLog from '@joplin/lib/services/synchronizer/syncDebugLog';
 import eventManager from '@joplin/lib/eventManager';
+import installDefaultPlugins from './installDefaultPlugins';
 // import { runIntegrationTests } from '@joplin/lib/services/e2ee/ppkTestUtils';
 
 const pluginClasses = [
@@ -261,7 +262,7 @@ class Application extends BaseApplication {
 		service.initialize(packageInfo.version, PlatformImplementation.instance(), pluginRunner, this.store());
 		service.isSafeMode = Setting.value('isSafeMode');
 
-		const pluginSettings = service.unserializePluginSettings(Setting.value('plugins.states'));
+		let pluginSettings = service.unserializePluginSettings(Setting.value('plugins.states'));
 
 		{
 			// Users can add and remove plugins from the config screen at any
@@ -273,6 +274,7 @@ class Application extends BaseApplication {
 		}
 
 		try {
+			pluginSettings = await installDefaultPlugins(pluginSettings, service);
 			if (await shim.fsDriver().exists(Setting.value('pluginDir'))) {
 				await service.loadAndRunPlugins(Setting.value('pluginDir'), pluginSettings);
 			}

packages/app-desktop/gui/ConfigScreen/ConfigScreen.tsx

@@ -60,12 +60,26 @@ class ConfigScreenComponent extends React.Component<any, any> {
 		this.setState({ settings: this.props.settings });
 	}
 
+	updatePluginsStates(value: any) {
+		const key = 'plugins.states';
+		const md = Setting.settingMetadata(key);
+		shared.updateSettingValue(this, key, value);
+
+		if (md.autoSave) {
+			shared.scheduleSaveSettings(this);
+		}
+	}
+
 	componentDidMount() {
 		if (this.props.defaultSection) {
 			this.setState({ selectedSectionName: this.props.defaultSection }, () => {
 				this.switchSection(this.props.defaultSection);
 			});
 		}
+		if (!Setting.value('updatedDefaultPluginsInstallStates')) {
+			this.updatePluginsStates(Setting.value('defaultPlugins'));
+			Setting.setValue('updatedDefaultPluginsInstallStates', true);
+		}
 	}
 
 	private async handleSettingButton(key: string) {

packages/app-desktop/installDefaultPlugins.ts

@@ -0,0 +1,22 @@
+import Setting from '@joplin/lib/models/Setting';
+import shim from '@joplin/lib/shim';
+import PluginService, { defaultPluginSetting, PluginSettings } from '@joplin/lib/services/plugins/PluginService';
+import path = require('path');
+import { filename } from '@joplin/lib/path-utils';
+import produce from 'immer';
+
+export default async function installDefaultPlugins(pluginSettings: PluginSettings, service: PluginService): Promise<PluginSettings> {
+	if (Setting.value('firstStart')) {
+		const defaultPlugins = await shim.fsDriver().readDirStats(path.join(__dirname, '..', 'app-desktop/build/defaultPlugins/'));
+		for (const plugin of defaultPlugins) {
+			const defaultPluginPath: string = path.join(__dirname, '..', `app-desktop/build/defaultPlugins/${plugin.path}`);
+			await service.installPlugin(defaultPluginPath, false);
+
+			pluginSettings = produce(pluginSettings, (draft: PluginSettings) => {
+				draft[filename(plugin.path)] = defaultPluginSetting();
+			});
+		}
+		Setting.setValue('defaultPlugins', service.serializePluginSettings(pluginSettings));
+		return pluginSettings;
+	} else { return pluginSettings; }
+}

packages/lib/models/Setting.ts

@@ -1504,6 +1504,22 @@ class Setting extends BaseModel {
 				storage: SettingStorage.Database,
 			},
 
+			updatedDefaultPluginsInstallStates: {
+				value: false,
+				type: SettingItemType.Bool,
+				public: false,
+				appTypes: [AppType.Desktop],
+				storage: SettingStorage.File,
+			},
+
+			defaultPlugins: {
+				value: {},
+				type: SettingItemType.Object,
+				public: true,
+				appTypes: [AppType.Desktop],
+				storage: SettingStorage.Database,
+			},
+
 			lastSettingDefaultMigration: {
 				value: -1,
 				type: SettingItemType.Int,
@@ -1516,6 +1532,13 @@ class Setting extends BaseModel {
 				public: false,
 			},
 
+			// isFirstAppStart: {
+			// 	value: true,
+			// 	type: SettingItemType.Bool,
+			// 	storage: SettingStorage.File,
+			// 	public: false,
+			// },
+
 			// 'featureFlag.syncAccurateTimestamps': {
 			// 	value: false,
 			// 	type: SettingItemType.Bool,

packages/lib/services/plugins/PluginService.ts

@@ -416,7 +416,7 @@ export default class PluginService extends BaseService {
 		return this.installPluginFromRepo(repoApi, pluginId);
 	}
 
-	public async installPlugin(jplPath: string): Promise<Plugin> {
+	public async installPlugin(jplPath: string, loadPlugin: boolean = true): Promise<Plugin | null> {
 		logger.info(`Installing plugin: "${jplPath}"`);
 
 		// Before moving the plugin to the profile directory, we load it
@@ -429,9 +429,11 @@ export default class PluginService extends BaseService {
 		await shim.fsDriver().copy(jplPath, destPath);
 
 		// Now load it from the profile directory
-		const plugin = await this.loadPluginFromPath(destPath);
-		if (!this.plugins_[plugin.id]) this.setPluginAt(plugin.id, plugin);
-		return plugin;
+		if (loadPlugin) {
+			const plugin = await this.loadPluginFromPath(destPath);
+			if (!this.plugins_[plugin.id]) this.setPluginAt(plugin.id, plugin);
+			return plugin;
+		} else { return null; }
 	}
 
 	private async pluginPath(pluginId: string) {