Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore the user-data-dir flag #5467

Merged
merged 1 commit into from
Sep 19, 2021
Merged

ignore the user-data-dir flag #5467

merged 1 commit into from
Sep 19, 2021

Conversation

marph91
Copy link
Contributor

@marph91 marph91 commented Sep 15, 2021

This change allows users to run the app together with chromedriver. The flag is passed by chromedriver and can't be suppressed there. In #2084 a related flag was ignored.

This flag is passed by chromedriver and can't be suppressed there.
@laurent22
Copy link
Owner

That makes sense, thanks for the update!

@laurent22 laurent22 merged commit 2d72d14 into laurent22:dev Sep 19, 2021
@marph91 marph91 deleted the ignore-user-data-dir branch September 20, 2021 12:22
marph91 added a commit to marph91/joplin-ui-tests that referenced this pull request Sep 25, 2021
This is possible, since laurent22/joplin#5467 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants