Desktop: Add keyboard shortcuts for inserting lists #5137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also the feature request at tinymce/tinymce#6700. I later realized that Joplin has its own
lists.js
plugin, so I implemented it there.Tested manually on Linux (KDE), it works.
Open questions:
Assets/TinyMCE/JoplinLists/src/main/ts/...
?addCommand()
calls)? There, they would be active even whenhasPlugin(editor, 'advlist')
-- not sure what that is and so I'm not sure which one makes sense. I.e. only add the keyboard shortcut if the button exists, or always?