Turndown: Fixes #5025: Convert inline katex html to its equivalent inline katex markdown #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…valent inline katex markdown
laurent22
reviewed
Jun 7, 2021
packages/turndown/test/index.html
Outdated
| \sqrt{3x} | ||
| $$</pre> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
We don't use these tests anymore, they are from the original source code that we've forked, so please remove these changes and move anything relevant to html_to_md directory
There was a problem hiding this comment.
Ohh ok, I will do that
|
Moved the tests from |
|
Looks good now, thanks for the fix @Subhra264! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5025
Currently, the turndown adds
'\n\n'around the content ofjoplin-sourceelement assuming it as a block element( even if thejoplin-editablenode is aspanelement). As a result, the inline katex expression insidejoplin-editablespan element, gets converted to Md, but on a new line even though it is an inline expression.This PR first checks if the
joplin-editableelement is an inline element, and then surrounds the content with relevant character.Tests :