Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop : Partially resolves #1718 : Adding Special Paste to Context menu #4676

Closed
wants to merge 1 commit into from
Closed

Desktop : Partially resolves #1718 : Adding Special Paste to Context menu #4676

wants to merge 1 commit into from

Conversation

ArenaGrenade
Copy link

I have only added to context menu in the editor. I am unable to link a shortcut for the same functionality. Any pointers would be appreciated.

I have also added the shortcut to the keymap service and it displays faithfully on the settings menu. The only part remaining is to bind this shortcut to the registered command(which is also done).

@laurent22
Copy link
Owner

I'm afraid we need a detailed spec of what this feature is going to do first. I can only suggest to take a look at the spec label and write down a similar document, so that before development starts we can all agree about the feature.

@laurent22 laurent22 closed this Mar 15, 2021
@ArenaGrenade
Copy link
Author

Hi! There was a discussion on this in the linked thread and I think people did come to an agreement and @roman-r-m accepted my working on this I think. I hope that is enough to be counted as specs of the idea?

@laurent22
Copy link
Owner

I had a look at the thread again and it wasn't entirely clear what the spec was. A spec is one document, not multiple ideas spread over a forum thread.

I guess we became a bit stricter about what we accept since that issue was created, otherwise we spend too much time on pull requests discussing what it should do, how to change it, etc. If we have a clear spec from the start we all save a lot of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants