Desktop: Fix Error: Cannot execute a command without a runtime #4343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4338 #4340 #4339
There is some discussion here.
@laurent22 the fix I've introduced here is to keep the focus code as a special case (which it always needed because of commands like
textLink
) and extended theisEditorCommand
function to cover all editor commands that do not start witheditor.
.I understand if you think this is an ugly solution (although it is an extension of what we were doing previously). And I'm open to having a discussion about what would be a cleaner way to deal with this.