- All: Resolves #4313: Quick onedrive delta fix #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would that break support for OneDrive Business? |
jonath92
commented
Jan 8, 2021
| const accountProperties = this.api_.accountProperties_; | ||
| const url = (accountProperties.accountType === 'business') ? `/drives/${accountProperties.driveId}/root/delta` : `${this.makePath_(path)}:/delta`; | ||
| const url = `/drives/${accountProperties.driveId}/root/delta`; |
There was a problem hiding this comment.
Here you can see that the url stays the same for OneDrive for Business
|
No. It has no changes for OneDrive for Business as the used URL stays the same. As far as I can the current problem shouldn't occur for OneDrive for Business users (however I can't test as I currently don't have access to a Business account and when you make a test account you need to wait about 24 hours before you can use the account). |
|
Thanks for the fix, then let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #4313
Onedrive currently gives always an "Resync required" error when making a delta request to a specific directory but not when making a request to the root. I will open an issue later at the Onedrive api docs and when it is working again we can revert the changes of this pr again as it is more efficient to make the request to the folder than filtering the delta response to only get the changes for the joplin folder. But it is definitely much better to filter the request than making a full resync each time.