Import <strike>,<s> tags (strikethrough) from Evernote #3936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am assuming the
~~
Markdown tags for strikethrough are a relatively recent addition because the import from Evernote replaces them with(
and)
as start and end markers.This PR is a naive change to simply replace the
(
and)
with~~
and~~
.It does the trick for importing to Markdown, but still has the same limitations for some edge cases, for example it will be ignored if there is trailing space before the closing
~~
. This also happens for other tags such as bold/italic, so there needs to be a more general fix for importing format tags.