Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mermaid to 8.8.1 #3853

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Bump mermaid to 8.8.1 #3853

merged 3 commits into from
Oct 9, 2020

Conversation

CalebJohn
Copy link
Collaborator

reference

It's probably worth it even just for this change which removes a bunch of console.log statements from mermaid.

Copy link
Collaborator

@tessus tessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also have to put it in ReactNativeClient/package.json because of the electron builder bug.

@CalebJohn
Copy link
Collaborator Author

@tessus Thanks, that was missing in my previous pull.

@laurent22
Copy link
Owner

Thanks for the update. Also when updating a package, please run "npm install" in each relevant directory to update package-lock (it will eventually get updated anyway but in an unrelated commit so it's better to do it now). As we're quite close to the v1.2 release, I'll merge it in v1.3.

@laurent22
Copy link
Owner

Ok it's good to merge, thanks!

@laurent22 laurent22 merged commit d965a7b into laurent22:dev Oct 9, 2020
@CalebJohn CalebJohn deleted the bump-mermaid branch October 9, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants