Desktop: Extend functionality of codemirror vim #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add swapLine(Up/Down) have `o` use the more complex list indent enable sync initializing from vim (and maybe emacs) split keymap stuff into it's own file
|
Thanks for the update! |
|
Hi Caleb, I am on Ubuntu 20.4 and using Joplin 1.2.6 and using the VIM key bindings. Following the update this afternoon to the new version (which is very nice!) I noticed that the 'o' key moves me down a line but does not enter INSERT mode. On the other hand, when I do 'O' it inserts a line above and does move me into INSERT mode. So the 'o' does not quite do what it is supposed to do but 'O' does. No biggie but a bit odd, no? |
|
@ShrubberRi Definitely odd! Especially given that I added that functionality using vim! #3897 will make it work as expected. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested on the forum and here
Changes:
add swapLine(Up/Down)
have
ouse the more complex list indentenable sync initializing from vim (and maybe emacs)
I also moved the keyMap stuff into it's own file because it was getting kinda large.