Desktop: Adjust the codemirror code block colors for the dark theme #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default color was typically very low contrast
laurent22
reviewed
Sep 22, 2020
| } | ||
|
|
||
| .cm-s-solarized.cm-s-light span.cm-comment { | ||
| color: #8ba1a7 !important; |
There was a problem hiding this comment.
Isn't it something that should be fixed in the theme files directly (eg. themes/nord.ts, etc.)?
There was a problem hiding this comment.
The theme files control the way Joplin components will look and be coloured but these changes are specific to the codemirror themes. AFAIK these aren't integrated yet.
There was a problem hiding this comment.
Ah yes, that's right. Ideally we'd submit a patch upstream but I don't know how responsive they are so let's add this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3793
I chose these colors by taking the defaults and adjusting the lightness until the contrast was high enough
