Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Load codemirror css in index.html #3673

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

CalebJohn
Copy link
Collaborator

reference

I couldn't pinpoint the exact cause of failure on this one, but it seems like codemirror doesn't like it when the css is lazy loaded. I think there is probably some form of race condition happening while it is initializing.

I figured the simplest solution would be to load the 8.5KB codemirror.css file in index.html. If that is too slow we could probably change this to add only the exact css needed in index.html and lazy load the rest of the file, but I don't think that's really worth the complexity.

@laurent22
Copy link
Owner

Ok I'm not sure what's causing the bug either so let's keep like this for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants