Desktop: Fixes #3628: Add scroll offset for dragging notes (ui_update branch) #3651
Conversation
The note draging was not taking into account the scroll distance. This caused the notes to be dragged to a different location than the mouse. This scroll offset should fix that issue.
| @@ -141,7 +141,7 @@ class NoteListComponent extends React.Component { | |||
| } | |||
|
|
|||
| dragTargetNoteIndex_(event:any) { | |||
| return Math.abs(Math.round((event.clientY - this.itemListRef.current.offsetTop()) / this.itemHeight)) - 1; | |||
| return Math.abs(Math.round((event.clientY - this.itemListRef.current.offsetTop() + this.itemListRef.current.offsetScroll()) / this.itemHeight)); | |||
There was a problem hiding this comment.
Was the - 1 at the end of the dragging notes calculation on purpose?
It is not currently in the dev branch.
It does not line up with the mouse if it is there. It makes the drag location 1 note high.
There was a problem hiding this comment.
Yes I've added that as the index somehow was off by 1 at some point while I was testing. But maybe it was some other issue, or your change fixes it properly. I'll give it a try to be sure.
There was a problem hiding this comment.
OK, I'm not sure which way it needs to be.
There was a problem hiding this comment.
I will test this change once I get back to the UI update, which should be relatively soon.
|
For some reason, I can't link the issue #3628 to this pull request. |
|
The fix was good, thanks @DarinDev1000! |
|
Thanks |
Fixes #3628
The note dragging was not taking into account the scroll distance.
This caused the notes to be dragged to a different location than the mouse.
This scroll offset should fix that issue.
This fix was moved to ui_update branch instead of dev branch.
Original pull request on dev branch