Desktop: Add scrollTo option to editor search highlighter #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only scroll to search matchs when the user changes the search or explicitly changes the search index https://discourse.joplinapp.org/t/codemirror-feedback/10397
|
Looks good too, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only scroll to search matches when the user changes the search or explicitly changes the search index
https://discourse.joplinapp.org/t/codemirror-feedback/10397
The main functional change here is that the
scrollIntoViewwill only be called if the keyword is the first in a multiple word search (this happens on the global search) and either the keyword has changed or the user has explicitly changed the index.I also made some changes to the
highlightSearchfunction because I noticed that it was creating an array and only adding one element to it 😆