Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Resolves #3529: Fix AppImage Icon #3570

Merged
merged 2 commits into from
Aug 2, 2020
Merged

Desktop: Resolves #3529: Fix AppImage Icon #3570

merged 2 commits into from
Aug 2, 2020

Conversation

Jesssullivan
Copy link
Contributor

@Jesssullivan Jesssullivan commented Jul 27, 2020

Appends && update-desktop-database ~/.local/share/icons in addition to ~/.local/share/applications.
Checked on Budgie 20.04 LTS.

@Tiger862000 Does this work for you on Pop!_OS?

@Jesssullivan
Copy link
Contributor Author

Resolves #3529- just double checked from a Pop VM:
image

@laurent22 laurent22 changed the base branch from master to dev August 2, 2020 11:17
@laurent22 laurent22 merged commit cc8c200 into laurent22:dev Aug 2, 2020
@Tiger862000
Copy link

@Jesssullivan and @laurent22
Sorry for the delay my PC was broken
It did not work for Pop!OS. Encountered the same problem with another application.
I installed Joplin as an Appimage.
As a workaround I had to select the icon manually using the AppEditor tool

@Jesssullivan
Copy link
Contributor Author

Jesssullivan commented Aug 31, 2020

@Jesssullivan and @laurent22
Encountered the same problem with another application.
I installed Joplin as an Appimage.

@Tiger862000 Are you installing the AppImage via the official Joplin install script?
(Not AppImageLauncher or linter)

Icon installs correctly in a fresh PopOS VM.

@nullbasis
Copy link

I just installed version 1.0.242 via the official install script on the homepage, and the desktop icon wasn't installed.

@Jesssullivan
Copy link
Contributor Author

I just installed version 1.0.242 via the official install script on the homepage, and the desktop icon wasn't installed.

What OS? Have you rebooted since installing?

@nullbasis
Copy link

Sorry, Ubuntu 20.04. I haven't rebooted, I don't usually need to do that when I install an appimage.

@Jesssullivan
Copy link
Contributor Author

Sorry, Ubuntu 20.04. I haven't rebooted, I don't usually need to do that when I install an appimage.

Screenshot from 2020-09-06 18-35-24
Hmm, cannot reproduce on 20.04-
perhaps try a sudo update-icon-caches /usr/share/icons/*?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants