Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning message when user tries to upload a file 10MB or larger #2102

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

marcushill
Copy link
Contributor

Resolving #2097

Copy link
Collaborator

@tessus tessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great (I've tested it). LGTM.

@@ -424,6 +424,11 @@ class Synchronizer {
const result = await Resource.fullPathForSyncUpload(local);
local = result.resource;
const localResourceContentPath = result.path;

if (local.size >= 10 * 1000* 1000) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (local.size >= 10 * 1000* 1000) {
if (local.size >= 10 * 1000 * 1000) {

@laurent22 laurent22 merged commit e84bafd into laurent22:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants