-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix toc with special characters - finally #2052
Conversation
I think that's indeed the right solution. Just to be sure, please could you check that it works with Russian and Chinese text headings too? Even better would be to have test units for this, but another time. |
Yep, will do. But after a 4h Skype session with a friend in Europe and 2 bottles of red wine I will postpone this task to tomorrow. ;-) |
Yes, it does. Added Japanese (which included a few Chinese characters) and Russion headings and it works like a charm. |
@laurent22 can we merge this now? |
Perfect, thanks for checking @tessus, it's good to merge then. |
@laurent22 here's the test code I used locally. Maybe you can use it for your test cases:
I used the |
subject says it all