Desktop: Stop watching external edits #1981
Conversation
|
Looks good, if you could just have a look at the two comments I left it can be merged. Of course, the onClose event won't be called when using a non-modal editor, but it's still an improvement for modal ones. What would be the purpose of watching resources? Is it to allow modifying them? |
Basically yes, it will allow for explicit edits, but also there are other times you might want to sync. For example my pdf viewer saves some metadata on where the last place I viewed the file was. This means that when I open the document again my location will be saved. It would be nice to have this metadata syncing across the Joplin environments. |
That makes sense. Support for editable resources would be very useful although I think some code here and there expect resources to never change, so that would need to be looked at. I don't know if the ResourceFetcher service would handle modified resources automatically either or if it would have to be tweaked a bit. |
|
@laurent I also added localization to that error. I noticed that none of that logging is localized, should I quickly go in and add _() call's to those now that it's imported? Or is logging generally not localized?
This is good to know, I realized it was going to be a bit more work than I originally thought, which is why I decided to split it up :) |
|
Yes we don't localise log statements and errors that are unlikely to happen. It allows keeping the locale files relatively small. So if you could remove the _() from this error that would be great. |
|
@laurent22 Done! |
|
Great, thanks @CalebJohn! |
…1981) * Stop watching external edits * move onClose to options * Wrap openExternal in promise * More specific error with locale * Removed localization of external edit error
)" Due to this issue: https://discourse.joplinapp.org/t/joplin-version-1-0-173/4232/7 This reverts commit 0eb51e6.
|
@CalebJohn, I have reverted the change in this commit: 15f09ef For me, I think it's only the "onClose" part that was causing a problem (because the launching process ends immediately) and not sure about the rest of the changes. If some of these changes can be restored, feel free to create a new pull request with them. |
My original intention was to start watching opened resources, but progress has been slow so I want to split it up into multiple pulls. This first pull slightly changes the file watching to watch for the close event. Currently all this means is that when a user closes an external editor they will see the icon return to normal.
The way I wrote the code here will hopefully pave the way for generalizing ExternalEditWatcher to support resources as well as notes.