Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: show correct time/date (as specified in settings) for note properties #1749

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Jul 15, 2019

I was finally able to get react-native run-android working, thus I tested the change accordingly.

see also #1745

@tessus tessus added bug It's a bug mobile All mobile platforms labels Jul 15, 2019
@laurent22
Copy link
Owner

Looks good, thanks! I guess unixMsToLocalDateTime should removed altogether since it's not used and not useful.

@laurent22 laurent22 merged commit d45d1b4 into laurent22:master Jul 16, 2019
@tessus
Copy link
Collaborator Author

tessus commented Jul 17, 2019

I guess unixMsToLocalDateTime should removed altogether since it's not used and not useful.

Yep, or we call formatMsToLocal from within unixMsToLocalDateTime :-) hahaha.

@tessus tessus deleted the fix-dates branch October 1, 2019 17:28
tessus added a commit to tessus/joplin that referenced this pull request Dec 5, 2020
```
Release Notes 8.8.4

    Re-align gantt chart dateFormat table with spaces (laurent22#1764) @AloisMahdal
    Docs/update edit this page (laurent22#1774) @sy-records
    Fixed typo in the docs (laurent22#1780) @manicki
    Move babel-eslint to devDependencies (laurent22#1772) @glensc
    Add Doscy to list of integrations (laurent22#1784) @gwatts
    Changed regex for multi-line state notes (laurent22#1773) @tomatoman25
    Add different id generators (laurent22#1787) @julianbei
    Bump highlight.js from 9.18.1 to 9.18.5 (laurent22#1789) @dependabot
    Fixed markdown error in Relationship Syntax (laurent22#1796) @kciter
    remove classDiagram duplicate options (laurent22#1786) @JiChao99
    Update copyright years (laurent22#1805) @BastianZim

🐛 Bug Fixes

    Add sans-serif to default font settings (laurent22#1776) @GDFaber
    ignore build files in dist folder (laurent22#1777) @GDFaber
    Narrow down console logging when flowchart subgraphs are added (laurent22#1782) @GDFaber
    Apply style settings to subgraphs in "flowchart" diagrams (laurent22#1781) @GDFaber

Release Notes 8.8.3

    Fix styling of links for new beta flowchart (laurent22#1730) @knsv
    Fix typo in pie.md (laurent22#1705) @hwine
    Fixing broken links and misspellings (laurent22#1727) @deining
    Fixed empty code examples (laurent22#1729) @Eraledm
    README: use stateDiagram-v2 (laurent22#1728) @alexislefebvre
    laurent22#1724 Adding fontawesome to edge labels (laurent22#1731) @knsv
    Fix broken links in gantt.md (laurent22#1703) @wontonst
    Replace fregante/setup-git-token with setup-git-user (laurent22#1735) @fregante
    Updated docs (laurent22#1739) @BastianZim
    1740 nested subgraps directions (laurent22#1741) @knsv
    Switching to Docsify and adding search (laurent22#1746) @NeilCuzon
    Fixed bad tertiary operator (laurent22#1743) @lishid
    fix broken links in README (laurent22#1749) @levlas

Release Notes 8.8.2

    1704 Revert to original behavior of nodes and subgraphs (laurent22#1709) @knsv

    There is some ambiguity about what subgraph a node belongs to when it appears in several subgraphs. Should it stick to the first subgraph it appears in, or should the last subgraph it gets added to be the one it belongs to. With this change the original behavior is retained.
```
laurent22 pushed a commit that referenced this pull request Dec 9, 2020
```
Release Notes 8.8.4

    Re-align gantt chart dateFormat table with spaces (#1764) @AloisMahdal
    Docs/update edit this page (#1774) @sy-records
    Fixed typo in the docs (#1780) @manicki
    Move babel-eslint to devDependencies (#1772) @glensc
    Add Doscy to list of integrations (#1784) @gwatts
    Changed regex for multi-line state notes (#1773) @tomatoman25
    Add different id generators (#1787) @julianbei
    Bump highlight.js from 9.18.1 to 9.18.5 (#1789) @dependabot
    Fixed markdown error in Relationship Syntax (#1796) @kciter
    remove classDiagram duplicate options (#1786) @JiChao99
    Update copyright years (#1805) @BastianZim

🐛 Bug Fixes

    Add sans-serif to default font settings (#1776) @GDFaber
    ignore build files in dist folder (#1777) @GDFaber
    Narrow down console logging when flowchart subgraphs are added (#1782) @GDFaber
    Apply style settings to subgraphs in "flowchart" diagrams (#1781) @GDFaber

Release Notes 8.8.3

    Fix styling of links for new beta flowchart (#1730) @knsv
    Fix typo in pie.md (#1705) @hwine
    Fixing broken links and misspellings (#1727) @deining
    Fixed empty code examples (#1729) @Eraledm
    README: use stateDiagram-v2 (#1728) @alexislefebvre
    #1724 Adding fontawesome to edge labels (#1731) @knsv
    Fix broken links in gantt.md (#1703) @wontonst
    Replace fregante/setup-git-token with setup-git-user (#1735) @fregante
    Updated docs (#1739) @BastianZim
    1740 nested subgraps directions (#1741) @knsv
    Switching to Docsify and adding search (#1746) @NeilCuzon
    Fixed bad tertiary operator (#1743) @lishid
    fix broken links in README (#1749) @levlas

Release Notes 8.8.2

    1704 Revert to original behavior of nodes and subgraphs (#1709) @knsv

    There is some ambiguity about what subgraph a node belongs to when it appears in several subgraphs. Should it stick to the first subgraph it appears in, or should the last subgraph it gets added to be the one it belongs to. With this change the original behavior is retained.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug mobile All mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants