-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to use soft breaks for markdown rendering #1408
Conversation
fixes #1406 |
I'd prefer all the Markdown rendering options to be under the same section - I think for users it will be easier to find. For now, to keep it simple, let's put it under the "plugins" section (it's not really a plugin but maybe later we can rename the section or arrange things differently). Also it means we can remove the description from the setting because from the section it will be implied it's about Markdown (as much as possible, it's better to reduce the localisable text we add to the app). |
I will put it under the plugins sections. I am on my way out, so I will look into it tomorrow. |
@laurent22 I've put it under the section "plugins". While I do understand that you want to minimize localizable text (which makes sense btw), I am afraid that the term "soft breaks" might not be understood easily, therefore I changed the text to |
I see what you mean but no matter what text we choose, it's an advanced setting that most users won't need (I only remember one person who ever asked about it), and So I'd prefer to keep it short and use |
Ok, here you go... |
Perfect, thanks @tessus! |
You are welcome! |
Woot. The one user that cares about it... really cares about it :) |
@taw00 it also came up on github and I also know people who use the traditional format. So you might not be the only one, but you were the one who was the most vocal about it. ;-) |
And I lived with the illusion that my fantastic issue sparked the development :D |
This PR adds an option to settings to use the traditional line-break behavior.
It is marked as
Work In Progress
because of the following 2 items:General
because it's a general markdown setting. We can always move it to a different section.breaks_
, because I thought it made the code more readable. I can remove it and use the ternary operation directly. Please advise.