Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deskotp: Legacy Markdown Editor: Fix styles in seconary windows and remove red focus-visible border #11614

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jan 9, 2025

Summary

This pull request:

  • Fixes an issue where legacy Markdown editor style overrides (e.g. font size, heading styles, etc.) weren't loaded in secondary windows.
  • Fixes an issue where the legacy Markdown editor had an orange :focus-visible border when spellcheck was enabled.

See the relevant forum post.

Note

This pull request fixes a regression and thus targets release-3.2.

Testing plan

  1. Start Joplin.
  2. Enable the legacy Markdown Editor.
  3. Enable spellcheck.
  4. Open a note in a new window.
  5. Focus the editor.
  6. Verify that no orange border is shown around the editor.
  7. Add a heading.
  8. Verify that the heading is in a larger font.

@personalizedrefrigerator personalizedrefrigerator changed the base branch from dev to release-3.2 January 9, 2025 09:26
@personalizedrefrigerator personalizedrefrigerator changed the title Deskotp: Legacy Markdown Editor: Fix styles in seconary windows and remove red border Deskotp: Legacy Markdown Editor: Fix styles in seconary windows and remove red focus-visible border Jan 9, 2025
@laurent22 laurent22 merged commit 877f39b into laurent22:release-3.2 Jan 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants