Android: Fix clicking "Draw picture" results in blank screen with very old WebView versions #11604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android 11 ships with a WebView based on Chromium 83. Although some devices update their WebView version through the PlayStore, not all devices do. This commit fixes an issue that prevented the image editor from running in these older WebView versions.
Comment on lines
-70
to
-72
| if (isJsFile) { | ||
| console.log('Compiling with Babel:', value); | ||
| } |
There was a problem hiding this comment.
After adding js-draw to the list of libraries to transiple, this line creates a large amount of console output (one line of output per referenced js-draw source file).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Android 11 ships with a WebView based on Chromium 83. This commit:
js-drawto the list of packages that need to be transpiled withbabelbefore creating injectedJsHTMLElement.replaceChildren.Note: Some devices upgrade the system WebView version (e.g. through the Google PlayStore). As such, before this pull request, the "Draw picture" feature may work correctly on many Android 11 and older devices.
Testing plan