Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Accessibility: Improve side menu and heading screen reader accessibility #11427

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Nov 21, 2024

Summary

This pull request makes the following accessibility-related changes:

  • Adds role=header to textual screen headers.
  • Fixes certain icons were interpreted as text by screen readers in the sidebar.
  • Changes role=button to accessibilityRole=button on several sidebar buttons.
    • At least on <TouchableOpacity>, role=button does not seem to be sufficient for TalkBack to recognize a button as a button.

@personalizedrefrigerator personalizedrefrigerator added mobile All mobile platforms accessibility Related to accessibility labels Nov 21, 2024
@laurent22 laurent22 merged commit 5dfbb18 into laurent22:dev Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility mobile All mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants