Mobile: Accessibility: Improve note list accessibility #11419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the accessibility of the mobile app's note list by:
react-native-vector-icons
, which uses an icon font. Previously, accessibility tools would attempt to read the checkbox icon as a character (unpronounceable with my current TalkBack settings).aria-checked
to checkboxes (for web).react-native-web
seems to requirearia-checked
for accessibility tools to read a checked checkbox as checked.accessibilityState={{ checked: true }}
for a checked checkbox to be read as checked.accessibilityHint
to note list buttons to describe the effect of clicking one of the buttons.Related to #10795.
Known unresolved issues
<Checkbox>
is contained within a<TouchableOpacity>
. VoiceOver only makes the parentTouchableOpacity
focusable.Testing plan
Android 13:
Example
Test
Test
Example
.Example, Button, Opens note
Test, Button, Opens note
.Double-tap to activate
.Test, Button, Opens note
.checked, to-do: Test, checkbox
.Double-tap to toggle
.Not checked
.