Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Fix build: Upgrade react-native-quick-crypto to v0.7.5 #11294

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Android: Fix build: Upgrade react-native-quick-crypto to v0.7.5 #11294

merged 2 commits into from
Oct 30, 2024

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Oct 30, 2024 •
edited
Loading

Summary

This pull request fixes a build failure caused by 05a588a. The original build failure is possibly related to margelo/react-native-quick-crypto#403.

Testing plan

  1. Open Android Studio
  2. Build.
  3. Verify that the build completes successfully.
  4. Deploy to a connected Android device.
  5. Verify that the startup "Crypto Tests" pass without logging an error.
    • Note: The upstream library is now logging 'sanitized input []' when pbkdf2 is used (upstream issue).

@personalizedrefrigerator personalizedrefrigerator mentioned this pull request Oct 30, 2024
Merged
personalizedrefrigerator referenced this pull request Oct 30, 2024
@renovate
Update dependency react-native-quick-crypto to v0.7.2 (#11285)
05a588a
@personalizedrefrigerator personalizedrefrigerator mentioned this pull request Oct 30, 2024
Merged
@laurent22 laurent22 merged commit 441021b into laurent22:dev Oct 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@personalizedrefrigerator @laurent22