Mobile: Fixes #9204: Handle callback url triggered app launch #11280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #9204 |
personalizedrefrigerator
added a commit
to personalizedrefrigerator/joplin
that referenced
this pull request
Oct 29, 2024
See test failures in laurent22#11280
laurent22
reviewed
Oct 30, 2024
laurent22
reviewed
Oct 30, 2024
|
Thanks for fixing this @tiberiusteng! |
|
Hi @laurent22, I've tried with latest Android versions (3.1.7) and looks like this patch is not included in current android release, is this intended? Am I correct to assume this will be included in 3.2 release? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing
Linking.addEventListenerwill only receive URLs triggered after app launch, addingLinking.getInitialURLduring app start to get the URL triggered app launch (if there's one).Compiled and tested on Fairphone 4 with both biometrics disabled and enabled:
Latest commit f4ee4a1 can't build due to
shim.attachFileToNotesignature change, so I tested with ff09937.