Fix window manager icon on linux #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix, and let's review if it gets broken in a future electron-builder release. |
|
thanks ; works great ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a weird one that I suspect will come up again when electron-builder is updated. For some reason the resources that are specified by
extraResourcesinpackage.jsonare placed one level up from the app directory even though they initially reside in the app directory itself. Unfortunately this fix means that the icon is messed up when running joplin in debug mode.I also added a desktop parameter into
package.jsonthis makes sure that the .desktop file generated by the appimage (if used) will have the correct icon name.Fixes #251