Chore: CI: Fix .eslintignore and .gitignore CI check passes when it should fail #10923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
yarn updateIgnoredwas run indirectly at the beginning ofrun_ci.sh(byyarn installfromapp-desktop'sgulpfile.ts). This causedcheckIgnoredFilesto pass in CI in cases where it should fail.To see why, observe that
checkIgnoredFiles1) reads the previous content of ignore files, 2) updates them, and 3) compares with the originals. As such, if the ignore files are updated (but not necessarily committed),checkIgnoredFilescan pass.Testing plan
A test commit has been pushed to this pull request that correctly caused CI to fail.