Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #10768: Make :w trigger sync in the beta editor's Vim mode #10778

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request fixes #10768 by mapping :w to "sync" in the beta markdown editor (as it is in the legacy CodeMirror 5 editor).

Testing plan

  1. Enable vim keybindings.
  2. Enable the beta markdown editor.
  3. Press Escape then :w.
  4. Verify that the sync action is triggered.
    • For me, this resulted in the "select a sync target" dialog being shown.
  5. Switch to the legacy markdown editor.
  6. Repeat steps 2-3.

This has been tested successfully on Ubuntu 24.04.

@laurent22 laurent22 merged commit 3fbb3b6 into laurent22:dev Jul 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:w syncing in VIM mode doesn't work (beta editor)
2 participants