Resolved console errors in dev mode #10666
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Issue:
Desktop: Starting in dev mode with dev tools docked to main window logs error #9821
Summary
This pull request addresses an issue where the application would throw a
TypeError
when started in development mode with dev tools docked to the main window.Problem
When starting the application in dev mode with dev tools docked to the main window, the following error was logged:
Steps to Reproduce
TypeError
.Root Cause
The issue was caused by
this.rootLayoutSize()
returningnull
, leading to an attempt to set properties on anull
value.Solution
The solution involves adding a null check before setting the
width
andheight
properties. Specifically:updateRootLayoutSize
to check ifthis.rootLayoutSize()
returnsnull
.null
, log an error message instead of setting properties.Code Changes