Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: Add Multi-factor authentication guide #10661

Closed
wants to merge 9 commits into from
Closed

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Jun 26, 2024

I'm adding a new markdown file with the information about MFA, recovery codes, how to enable, disable and how to make a login with the recovery code.

@pedr pedr requested a review from laurent22 June 26, 2024 22:28
somewhere safe. Each code can only be used once, but you can generate new codes,
if necessary, from your profile page.

### How to enable MFA
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the ### should be ## (since they are not all a sub-section of Recovery codes)

@@ -0,0 +1,59 @@
# Multi-factor authentication

You can now enable Multi-Factor Authentication (MFA) to your Joplin Account.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the whole document, please don't add line breaks in paragraphs. We generally don't rely on soft breaks and I don't know how scripts along the pipeline to build the website are going to handle them. So essentially each paragraph should be on a single line

If you need to make login with your recovery code, when you are prompt to enter
your authentication code in the login screen you will see a link called
*Use a recovery code*. In this screen you have a new input field for the recovery
code.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc is well written but I wonder if we should aim to make it shorter. Partly because, well, users don't like to read the manual, and partly because it's more to maintain and translate. Have a look at at how it's done for example on Dropbox or OneDrive: https://help.dropbox.com/account-access/enable-two-step-verification https://support.microsoft.com/en-us/account-billing/how-to-use-two-step-verification-with-your-microsoft-account-c7910146-672f-01e9-50a0-93b4585e7eb4

It's essentially click here, then follow the instructions. That means our instructions during the process should be clear enough, so that we can keep the doc here to a minimum.

Also I think any process we describe (click here, click there), should be in bullet points.

I think the section titles you have are fine, just the content should be more concise, or bullet points

@pedr
Copy link
Collaborator Author

pedr commented Jun 27, 2024

Thanks for the suggestions, especially about the bullet points, it makes a lot of sense.

I also added a new section about what app the user can use, not sure what we might want to recommend. I personally only use Bitwarden, I guess Authy/Google Authenticator are simple enough for most cases if the user doesn't want a password manager

@pedr
Copy link
Collaborator Author

pedr commented Jun 27, 2024

  • Remove recommendations

readme/apps/mfa.md Outdated Show resolved Hide resolved

You can now enable Multi-Factor Authentication (MFA) to your Joplin Account. MFA enhances your account security by requiring more than just a password to log in.

If you can't generate your authentication code because you have lost access to your smartphone, for example, you will need to use one of the recovery codes to log in.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move under "Recovery codes" section

readme/apps/mfa.md Outdated Show resolved Hide resolved

## Recovery Codes

When you enable MFA, Joplin Cloud will show you a list of codes, that you should save in somewhere safe. Each code can only be used once, but you can generate new codes, if necessary, from your profile page.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the "Recovery codes" section after "How to disable MFA"

- Click the link to *Enable Multi-Factor Authentication*
- Follow the instructions shown in the page

If successful you should see a notification and a new page with your recovery codes, **remember to save them**.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line can be removed as we already say that in the Recovery codes section

readme/apps/mfa.md Outdated Show resolved Hide resolved

- [Access your profile](https://joplincloud.com/users/me)
- Find the *Multi-factor authentication* section
- Click the link to *Recovery Codes*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the link called? We should put the name as the grammar is not right here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I understand your suggestion.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurent22 I'm not sure what change is needed here, can you help me?


- [Access your profile](https://joplincloud.com/users/me)
- Find the *Multi-factor authentication* section
- Click the link to *Recovery Codes*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix grammar

@laurent22
Copy link
Owner

For some reason GitHub won't let me merge it from here, so I've pulled it locally in 5f34a1b

@laurent22 laurent22 closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants