Server: Fixes #10118: Missing record validation before trying to add item to user

[pedr]

Fixes #10118

The error:

app-1        | 07:50:18 0|app  | 2024-03-14 07:50:17: [error] TaskService: On #10 (Process orphaned items) TypeError: Cannot use 'in' operator to search for 'name' in undefined
app-1        | 07:50:18 0|app  |     at UserItemModel.<anonymous> (/home/joplin/packages/server/src/models/UserItemModel.ts:126:17)
app-1        | 07:50:18 0|app  |     at Generator.next (<anonymous>)
app-1        | 07:50:18 0|app  |     at /home/joplin/packages/server/dist/models/UserItemModel.js:8:71
app-1        | 07:50:18 0|app  |     at new Promise (<anonymous>)
app-1        | 07:50:18 0|app  |     at __awaiter (/home/joplin/packages/server/dist/models/UserItemModel.js:4:12)
app-1        | 07:50:18 0|app  |     at /home/joplin/packages/server/src/models/UserItemModel.ts:124:41
app-1        | 07:50:18 0|app  |     at UserItemModel.<anonymous> (/home/joplin/packages/server/src/models/BaseModel.ts:221:19)
app-1        | 07:50:18 0|app  |     at Generator.next (<anonymous>)
app-1        | 07:50:18 0|app  |     at fulfilled (/home/joplin/packages/server/dist/models/BaseModel.js:5:58)
app-1        | 07:50:18 0|app  |     at processTicksAndRejections (node:internal/process/task_queues:95:5)

While I could not reproduce the error, I think it is safe to assume that it could happen during the ItemModel.processOrphanedItems.

Basically what would happen is that a item would be orphaned, the processOrphanedItems would start and while it was happening the file was deleted before the process had time added the item back to the user collection.

That means that when UserItemModel.add happened, it would not found a item record anymore, which end up causing the error inside the UserItemModel.addMulti.

Testing

At first, I tried to add a more complex test that emulated the behavior, but it was getting very complicated and taking a lot of time, If the reviewer's opinion is different I can try to reproduce the behavior, but the simple test I added already will cover the potential regression if someone removes one of the checks.

[pedr]

• Add a error message on add( function and remove validation on addMulti