-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile: Fix plugins aren't visible after switching to a new profile #10386
Merged
laurent22
merged 15 commits into
laurent22:dev
from
personalizedrefrigerator:pr/mobile-plugin-support/fix-plugins-after-switch-profiles
May 2, 2024
Merged
Mobile: Fix plugins aren't visible after switching to a new profile #10386
laurent22
merged 15 commits into
laurent22:dev
from
personalizedrefrigerator:pr/mobile-plugin-support/fix-plugins-after-switch-profiles
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port/plugin-before-enable-info
…port/plugin-before-enable-info
…port/plugin-before-enable-info
#10348 is merged now but as a result there are some conflicts |
…port/fix-plugins-after-switch-profiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where plugins weren't visible in settings after switching to a new profile, despite being installed.
Note: Review #10348 first.
Notes
Important
This pull request builds on the changes made in #10348 (which has not yet been merged). This is done to avoid a regression that would cause the background webview to load even when no plugins are installed/plugin support has not been enabled.
Previously, the background plugin runner WebView was loaded only if settings existed for at least one plugin:
joplin/packages/app-mobile/plugins/PluginRunner/PluginRunnerWebView.tsx
Line 83 in 443e04b
This may not be the case if the user switches profiles, in which case this setting would be empty. However, plugins are still installed and installing one additional plugin would cause all plugins to be loaded.
The
PluginStates
setting screen previously also relied onpluginSettings
. As a result, plugins installed in a different profile could run in the background with no UI in the plugin settings screen. This has been fixed by makingPluginStates
get information about the loaded plugins directly fromPluginService
rather than from settings and Redux state.Testing
This pull request has an automated test. The test checks that installing and uninstalling plugins updates the plugin settings screen.
To test this manually,
This has been tested successfully tested on Android 13.