Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting feedback on the New to-do and New note redesign #7848

Closed
julien-me opened this issue Feb 27, 2023 · 4 comments
Closed

Collecting feedback on the New to-do and New note redesign #7848

julien-me opened this issue Feb 27, 2023 · 4 comments
Labels
desktop All desktop platforms

Comments

@julien-me
Copy link
Contributor

julien-me commented Feb 27, 2023

The redesign of the buttons to create new notes and new todos opened some discussions regarding its current implementation and possible improvements.

Below are the comments that were made.

1) The new design could be more responsive.
Right now the buttons expand and shrink with the width of the note list but when the list is below a certain width the buttons overflow.
overflow

It was suggested to make the buttons responsive so that the text displayed shortens instead of overflowing. For instance "New" could be removed below a certain width and if the width shrinks further instead of text we could show the icons of the previous design.

2) Combine the two lines when the note list is wide enough
Vertical space is precious on small screens and for this reason when the note list is wide enough we could put the search bar and the buttons on one line. It's especially prevalent with a vertical layout.

1/4 => New note
1/4 => New to do
2/4 => Search bar (+filter button)

two-lines

3) Bug: Do not hide buttons when the focus in on Search
Buttons don't need to disappear anymore when a user clicks on the search bar. This was originally done so that the search bar could expand.
buttons-disappear

4) Bug: The two lines don't align when the sort buttons are disabled.

@julien-me julien-me added bug It's a bug desktop All desktop platforms and removed bug It's a bug labels Feb 27, 2023
@laurent22
Copy link
Owner

@julien-me, for this please create a separate pull request for each item

@uiop-on
Copy link

uiop-on commented Feb 27, 2023

Vertical space is at a premium so suggest keeping the three items (search, sort, new) on one line as far as possible. I only ever use 'New note' so 'New to-do' could easily be removed for me (or maybe a toggle option in settings). Then the button text can be a much shorter and simpler "New".

@tomasz1986
Copy link

tomasz1986 commented Mar 12, 2023

The current iteration still has the problem of unusable space when using the note-list-at-the-top layout:

image

The highlighted area is unusable. This can be easily reproduced as long as your note list is long enough. The same issue was already fixed previously, however it has now come back due to the newly implemented responsive layout which moves all four elements to a single line which also changes the height.

@laurent22
Copy link
Owner

Added here: #7848 (comment)

Repository owner locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
desktop All desktop platforms
Projects
None yet
Development

No branches or pull requests

4 participants