"Move line Up" and "Move Line Down" shortcuts don't work in note list

[TaoK]

Environment

Joplin version: Joplin 2.9.17 (prod, win32)
Platform: Windows
OS specifics: 10

Steps to reproduce

1. Enable custom sort
2. Select a note in a notebook with multiple notes (in the note list)
3. Press the "Move Line Up" or "Move Line Down" shortcuts - Alt-Up, Alt-Down in Windows

Describe what you expected to happen

I expected the selected Note(s) to be moved up or down by one position.

Instead, the selection just changed as though I had pressed Up or Down without the Alt modifier

Logfile

(n/a)

[Polaris66]

Hi, I would like to work on this issue.

[TaoK]

Be my guest! Please note this issue is unvalidated by any project members afaik - one could argue that this is not a "bug" but rather an "enhancement". I would disagree, which I why I created this issue, but full disclosure :)

One other thing you should be aware of before starting, if you're not already, is there there are some potentially-surprising bugs that might bite you when you do custom sorting: #4162 (comment)

Until those issues are addressed (I have pull requests open or in preparation), you will want to:

• Keep the "Uncompleted to-dos on top" box unchecked
• Keep the "Show completed to-dos" box checked
• When you add new notes, always reorder once (letting them pop to the top) before testing sane reorder behavior

[Polaris66]

Hi, I have worked on it and sent a pull request. Please see the same. Regards, Dhruv Arora

…

On Mon, 13 Feb, 2023, 2:23 pm Tao Klerks, ***@***.***> wrote: Be my guest! Please note this issue is unvalidated by any project members afaik - one could argue that this is not a "bug" but rather an "enhancement". I would disagree, which I why I created this issue, but full disclosure :) One other thing you should be aware of before starting, if you're not already, is there there are some potentially-surprising bugs that might bite you when you do custom sorting: #4162 (comment) <#4162 (comment)> Until those issues are addressed (I have pull requests open or in preparation), you will want to: - Keep the "Uncompleted to-dos on top" box unchecked - Keep the "Show completed to-dos" box checked - When you add new notes, always reorder once (letting them pop to the top) before testing sane reorder behavior — Reply to this email directly, view it on GitHub <#7692 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APLESFJ7RWO7I4F5GMI56TTWXHZBHANCNFSM6AAAAAAULD27ZA> . You are receiving this because you commented.Message ID: ***@***.***>

[TaoK]

Pull request in question is #7755 .

[Polaris66]

Also, I would like to work on the rest of the pull requests concerning custom sort after this one goes through.

…

On Mon, 13 Feb, 2023, 2:23 pm Tao Klerks, ***@***.***> wrote: Be my guest! Please note this issue is unvalidated by any project members afaik - one could argue that this is not a "bug" but rather an "enhancement". I would disagree, which I why I created this issue, but full disclosure :) One other thing you should be aware of before starting, if you're not already, is there there are some potentially-surprising bugs that might bite you when you do custom sorting: #4162 (comment) <#4162 (comment)> Until those issues are addressed (I have pull requests open or in preparation), you will want to: - Keep the "Uncompleted to-dos on top" box unchecked - Keep the "Show completed to-dos" box checked - When you add new notes, always reorder once (letting them pop to the top) before testing sane reorder behavior — Reply to this email directly, view it on GitHub <#7692 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APLESFJ7RWO7I4F5GMI56TTWXHZBHANCNFSM6AAAAAAULD27ZA> . You are receiving this because you commented.Message ID: ***@***.***>

[TaoK]

I would like to work on the rest of the pull requests concerning custom sort after this one goes through.

Not sure which ones you mean. As far as I know, this is the full set of custom sort related issues reported:

• Issue Custom sort order not synchronized #6956 : I have pull request All: Fixes #6956: set updated_time when a note's custom sort order is updated, so it syncs  #7729 merged
• Issue Changing Custom Sort is unpredictable with completed Todo items #7731 : I have pull request Desktop: Fixes #7731: Make note sort update logic use correct prior sort and drop-grouping #7737 in progress
• Issue With Custom Sort, new notes appear at bottom and later randomly "pop" to the top #7741 : I have pull request Desktop: Fixes #7741: initialize order without moving notes #7765 in progress
• Issue Desktop: drag-dropping notes to top or bottom, in custom sort, is hard/finicky #7776 : I have pull request Desktop: Move note sort drop handler to ItemList to enlarge dropzone downwards #7777 in progress
• Drag/Drop minor "thick line" display issue (on Windows): No issue number yet, open for work
• Issue Cannot sort on Android #4989 (no sort order adjustment feature in Android), open for work

[Polaris66]

Sounds like you have most of these issues covered already so I will find something else to work on. I was thinking of maybe working on a plugin for auto complete/ intellisence if it doesn't exist already.

…

On Mon, 13 Feb, 2023, 4:46 pm Tao Klerks, ***@***.***> wrote: I would like to work on the rest of the pull requests concerning custom sort after this one goes through. Not sure which ones you mean. As far as I know, this is the full set of custom sort related issues reported: - Issue #6956 <#6956> : I have pull request #7729 <#7729> in progress - Issue #7731 <#7731> : I have pull request #7737 <#7737> in progress - Issue #7741 <#7741> : I have a couple of commits ready, but they build on #7737 <#7737> so I have not submitted them yet - Drag/Drop precision issues at top/bottom: No issue number yet, open for work - Drag/Drop minor "thick line" display issue (on Windows): No issue number yet, open for work - Issue #4989 <#4989> (no sort order adjustment feature in Android), open for work — Reply to this email directly, view it on GitHub <#7692 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APLESFMVXKV3EASM2NGKFZTWXIJZZANCNFSM6AAAAAAULD27ZA> . You are receiving this because you commented.Message ID: ***@***.***>