Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joplin not responding when draw mermaid with indentation #5295

Closed
shelllee opened this issue Aug 12, 2021 · 7 comments · Fixed by #5448
Closed

joplin not responding when draw mermaid with indentation #5295

shelllee opened this issue Aug 12, 2021 · 7 comments · Fixed by #5448
Labels
bug It's a bug renderer About the note renderer upstream There's a problem with upstream code.

Comments

@shelllee
Copy link

shelllee commented Aug 12, 2021

platform:Windows10

image

  1. encryption is enabled
  2. mermaid gitGraph works well without indentation
  3. i could click the menu but nothing render out, seems the render run into an infinite loop
  4. i installed only one plugin: PlantUML
@shelllee shelllee added the bug It's a bug label Aug 12, 2021
@shelllee shelllee changed the title joplin not responding when draw mermaid with tab joplin not responding when draw mermaid with indentation Aug 12, 2021
@laurent22
Copy link
Owner

what does it do? It's frozen or just slow?

@roman-r-m
Copy link
Collaborator

Are you sure it's about the indentation?

I was trying to reproduce it and was typing the note (a JEX would have helped btw 😉 ) and as I got to the 1st

commit
commit

Joplin froze. This was without any indentation - was planning to add it later.

@roman-r-m
Copy link
Collaborator

Well, what do you know - there's an open issue in the mermaid-js repo with pretty much the same code: mermaid-js/mermaid#1677

@roman-r-m roman-r-m added upstream There's a problem with upstream code. renderer About the note renderer labels Aug 12, 2021
@laurent22
Copy link
Owner

Infinite loop crash that's not fixed after one year. A bit worrying but let's see if they'll eventually fix it.

@laurent22
Copy link
Owner

Looks like gitgraph is experimental so I'll see if I can disable it for now, because we shouldn't have plugins that crash the app.

@shelllee
Copy link
Author

what does it do? It's frozen or just slow?

  1. seems frozen,the menu could clicked,but nothing popup (maybe the render not work?)
  2. cpu 20%+

@shelllee
Copy link
Author

shelllee commented Aug 13, 2021

Are you sure it's about the indentation?

I was trying to reproduce it and was typing the note (a JEX would have helped btw 😉 ) and as I got to the 1st

commit
commit

Joplin froze. This was without any indentation - was planning to add it later.

not sure, but mermaid gitGraph works well without indentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug renderer About the note renderer upstream There's a problem with upstream code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants