Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource ID not provided error when click link with markdown pane closed #4891

Closed
hp6393 opened this issue Apr 27, 2021 · 5 comments · Fixed by #4943
Closed

Resource ID not provided error when click link with markdown pane closed #4891

hp6393 opened this issue Apr 27, 2021 · 5 comments · Fixed by #4943
Labels
bug It's a bug desktop All desktop platforms editor high High priority issues

Comments

@hp6393
Copy link

hp6393 commented Apr 27, 2021

A markdown link in one folder that points to a note in another folder does not work and throws a "Resource ID not provided" error when the markdown pane is closed (only the WYSIWYG editor is visible) but works fine when the markdown pane is visible.

Environment

Joplin version:
Platform:
OS specifics: Windows 10 64-bit

Joplin 1.7.11 (prod, win32)

Client ID: 447e55cf95a4441ca8a84eb7ace2bb05
Sync Version: 2
Profile Version: 34
Keychain Supported: Yes

Revision: f560563 (master)

Steps to reproduce

  1. Right-click on an existing note
  2. Copy markdown link
  3. Move to a new notebook
  4. Create a new note
  5. Paste the link into the markdown editor -- e.g., Regression
  6. At this point the markdown link appears in the Markdown editor and a clickable link labeled Regression appears in the WYSIWYG editor with the Joplin icon to the left of the link.

image

  1. As long as the editor is toggled so that the markdown editor is in the left pane and the WYSIWYG editor is in the right pane, clicking on the link in the WYSIWYG pane behaves normally--clicking on the link takes you to the Joplin note. But...
  2. Toggle the editor off (so that only the WYSIWYG editor is visible and the markdown editor is hidden.
  3. Click the link in the WYSIWYG editor and nothing happens.
  4. Right click and choose Open and an error window appears "Resource ID not provided"

image

Describe what you expected to happen

I expect that clicking on the WYSIWYG link would take me to the Joplin note regardless of whether the markdown editor pane is open or closed.

@hp6393 hp6393 added the bug It's a bug label Apr 27, 2021
@JackGruber
Copy link
Contributor

JackGruber commented Apr 27, 2021

As long as the editor is toggled so that the markdown editor is in the left pane and the WYSIWYG editor is in the right pane

To clarify this is the Split view of the markdown editor and the viewer, not the WYSIWYG editor!

I can reproduce the error with notelinks in the WYSIWYG editor in Joplin 1.8.2.

  • Splitview: Works
  • Viewer: Works
  • WYSIWYG ctrl + click on link Works
  • WYSIWYG right click on link and choose open: Resource ID not provided

@laurent22 laurent22 added desktop All desktop platforms editor high High priority issues labels Apr 27, 2021
@hp6393
Copy link
Author

hp6393 commented Apr 28, 2021 via email

@nishantwrp
Copy link
Contributor

I'm working on this issue.

@Subhra264
Copy link
Contributor

Extremely sorry for the inconvenience @nishantwrp, I was actually working on this issue ( see https://discourse.joplinapp.org/t/resource-id-not-provided-error-in-desktop-tinymce-editor/17147 ) and have found a solution to fix this bug( I guess ). However, feel free to give your suggestions/opinions about the implementation on the thread 😊😊.

@nishantwrp
Copy link
Contributor

Ah okay no problem. I'll pick another issue to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms editor high High priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants