Search result with tasks and notes

[ghost]

A search with a query like notebook:notebook1 give as result, notes and tasks completed and not completed.

Tasks completed are also shown if the option “show completed to-dos” is unchecked.

The filter iscompleted:0 is not useful because in this case notes are not visible.

Environment

Joplin version: 1.7.11
Platform: Windows
OS specifics: Win10

Steps to reproduce

1. Add notes and tasks checked and unchecked in your notebook1
2. Be sure the option “show completed to-dos” is unchecked (View menu)
3. Type this query in the search field : notebook:notebook1

Describe what you expected to happen

Not show completed tasks when “show completed to-dos” is unchecked.

[nishantwrp]

@laurent22, Can I work on this issue? Also, can you please confirm that it is a valid bug and this behaviour is not intentional?

[laurent22]

I don't know, for now we're only trying to fix issues that have been triaged, so which have additional labels like "high" or "medium".

[ghost]

Perhaps this issue fix from naviji could help for this bug.

[arpitg24]

I have fixed the issue, I'll make a PR shortly after I finish running the test units :)

[arpitg24]

I'm facing this issue in lib/services/searchengine/SearchEngineUtils.ts
In line 42 I added:

for (let i = 0; i < notes.length; i++) {
        if(!notes[i].todo_completed){      // added this if statement
          const idx = noteIds.indexOf(notes[i].id);
          sortedNotes[idx] = notes[i];
          if (idWasAutoAdded) delete sortedNotes[idx].id;
      	}
}

I get the error:TypeError: Cannot read property 'encryption_applied' of undefined
when i search for something.
I cant figure out what the issue is here.

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

[ghost]

Yes

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

[ghost]

Thank you @JackGruber 😀