Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid erDiagram not working in Joplin 1.1.1 #3740

Closed
MHoeller opened this issue Sep 12, 2020 · 3 comments · Fixed by #3745
Closed

Mermaid erDiagram not working in Joplin 1.1.1 #3740

MHoeller opened this issue Sep 12, 2020 · 3 comments · Fixed by #3745

Comments

@MHoeller
Copy link

A mermaid erDiagram is not rendered in Joplin 1.1.1

Environment

Joplin version: 1.1.1
Platform: AppImage
OS specifics: Ubuntu 20.04 LTS

Steps to reproduce

Add mermaid code to a notebook:

erDiagram
    CUSTOMER ||--o{ ORDER : places
    ORDER ||--|{ LINE-ITEM : contains
    CUSTOMER }|..|{ DELIVERY-ADDRESS : uses
Loading

This code is not rendered. The rendering in general seems to work since this code IS renderd:

graph TD;
    A-->B;
    A-->C;
    B-->D;
    C-->D;
Loading

The mermaid syntax should be ok, the example is take from the mermaid page

@MHoeller MHoeller added the bug It's a bug label Sep 12, 2020
@CalebJohn
Copy link
Collaborator

It looks like erDiagrams were added in mermaid 8.5.0. And Joplin uses mermaid 8.4.6, so these diagrams are not supported in Joplin currently.

@laurent22 would you accept a pull bumping the mermaid version? It seems like the last few release have (8.8.0 and 8.7.0) have primarily been focused on bug fixing.

@laurent22
Copy link
Owner

Yes sure, feel free to go ahead and update, provided there's no breaking changes. Also make sure you run npm run buildAssets from the joplin-renderer folder to make sure all assets are installed properly.

@tessus tessus removed the bug It's a bug label Sep 16, 2020
@tessus
Copy link
Collaborator

tessus commented Sep 16, 2020

Duplicate of #3108

@tessus tessus marked this as a duplicate of #3108 Sep 16, 2020
@tessus tessus closed this as completed Sep 16, 2020
laurent22 added a commit that referenced this issue Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants