Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code editor with dark themes is unreadable in v1.0.217 #3337

Closed
alexdevero opened this issue Jun 7, 2020 · 1 comment · Fixed by #3338
Closed

Code editor with dark themes is unreadable in v1.0.217 #3337

alexdevero opened this issue Jun 7, 2020 · 1 comment · Fixed by #3338
Labels
bug It's a bug

Comments

@alexdevero
Copy link
Contributor

alexdevero commented Jun 7, 2020 •
edited
Loading

Code editor with any dark theme is unreadable in v1.0.217.

Note: I am not using any custom CSS.

Environment

Joplin version: v1.0.217
Platform: Windows
OS specifics: Windows 10

Steps to reproduce

  1. Dowload v1.0.217
  2. Apply dark theme from presets
  3. Make sure to use Code view

Describe what you expected to happen

The text will be readable as it was in previous version.

Screenshot

joplin v1 0 217
@alexdevero alexdevero added the bug It's a bug label Jun 7, 2020
@CalebJohn CalebJohn mentioned this issue Jun 7, 2020
Merged
@CalebJohn
Copy link
Collaborator

Thanks for reporting this, this was a stupid mistake on my part (typo). Since you're on the cutting edge please do try out the new beta code editor (can be toggled under the note settings). The editing experience should be a bit nicer.

laurent22 pushed a commit that referenced this issue Jun 7, 2020
@CalebJohn
Desktop: Fixes #3337: Fixed regression when applying theme for Ace Ed…
005bfe7 
…itor (#3338)
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug It's a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Desktop: Actually apply theme for ace editor CalebJohn/joplin
2 participants
@CalebJohn @alexdevero