Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White-Space preventing selected text to be converted into Bold/Italics if the selected text ends or starts with a white-space #2573

Closed
Rishabh-malhotraa opened this issue Feb 24, 2020 · 5 comments · Fixed by #2582
Labels
bug It's a bug

Comments

@Rishabh-malhotraa
Copy link
Contributor

Rishabh-malhotraa commented Feb 24, 2020

BUG

If you select a line and press the bold button if the line has a white space, in the end, the text does not get bold(or italics)

Problem

  • White space in the beginning

  • White space at the end

BUG

EXPECTED BEHAVIOR

DEBUG 2

@Rishabh-malhotraa Rishabh-malhotraa added the bug It's a bug label Feb 24, 2020
@Rishabh-malhotraa
Copy link
Contributor Author

Rishabh-malhotraa commented Feb 24, 2020

Can I work on this @laurent22 @PackElend @tessus

plus the solution to this seems pretty straight forward,

just remove the white spaces I believe before and after the selected text -> add the Markdown-code -> and the readd the white space
for example

Suppose the selected text is " Hello world " (double quotes are just placeholders to show whitespace)

  • Remove the white space "Hello world"
  • Add the Markdown rule "Hello world"
  • Re-add the white spaces again " Hello world "

I'm not really sure about the third step, should I re-add the white space or let the text be as it is

@PackElend
Copy link
Collaborator

what tool you are using for the screen records?

@PackElend
Copy link
Collaborator

but check changes in #2565

@Rishabh-malhotraa
Copy link
Contributor Author

what tool you are using for the screen records?

Screen to gif

@Rishabh-malhotraa
Copy link
Contributor Author

but check changes in #2565

Alright, I'll do the same and get you back with the PR ASAP ^^

laurent22 pushed a commit that referenced this issue Feb 27, 2020
…ng formatting (#2582)

* fixes #2573 

This fixes the bug with spaces

* Update NoteText.jsx
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants